This answer depends on the manufacturer of the water heater, and the quality of the installation and maintenance.   

On average, you should expect 10-15 years from hot water tanks.

Tankless water heaters are usually more efficient and can last 15-20+ years.